Skip to content

Update VIF codes and fields.#22

Merged
stankudrow merged 18 commits into
developfrom
update-vif-codes-n-fields
Jun 3, 2025
Merged

Update VIF codes and fields.#22
stankudrow merged 18 commits into
developfrom
update-vif-codes-n-fields

Conversation

@stankudrow
Copy link
Copy Markdown
Owner

@stankudrow stankudrow commented May 28, 2025

Yet another attempt to find balance among minimalism and usability concerning VIFCode selection and what kind of objects they are desirable to be.

Features:

  • leave only two enums: VIFCodeKind (description) and VIFCodeUnit (units)
  • add table codes for 0xFB and 0xFD codes
  • one get_code function for all table management (tunable with extension_byte kwarg)

Supplementary changes:

  • rename unit attribute of the VIF and VIFE classes to data

Unrelated changes:

  • bump version up to v0.5.0
  • some tests groomed
  • coverage level increased up to 95%

@stankudrow stankudrow self-assigned this May 28, 2025
Comment thread src/pymbus/codes/vif.py
Comment thread src/pymbus/codes/vif.py
Comment thread src/pymbus/codes/vif.py
Comment thread src/pymbus/codes/vif.py
Comment thread src/pymbus/codes/vif.py Outdated
@stankudrow stankudrow merged commit ac06d05 into develop Jun 3, 2025
5 checks passed
@stankudrow stankudrow deleted the update-vif-codes-n-fields branch June 3, 2025 12:14
@stankudrow stankudrow mentioned this pull request Jun 3, 2025
stankudrow added a commit that referenced this pull request Jun 3, 2025
* modify VIFCode entities and selection tools

* lint the code base

* update the version -> v0.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant