Skip to content
This repository was archived by the owner on Apr 2, 2025. It is now read-only.

Conversation

@philvarner
Copy link
Contributor

@philvarner philvarner commented Nov 22, 2024

Related Issue(s):

  • n/a

Proposed Changes:

  1. refactor Order and OrderCollection to not extend Feature and FeatureCollection, to allow for tighter type constraints. This was a request from Jarrett.

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner requested a review from jkeifer November 22, 2024 21:20
@philvarner philvarner marked this pull request as ready for review November 22, 2024 21:20
Copy link

@trevorskaggs trevorskaggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :shipit:

@philvarner
Copy link
Contributor Author

Updated geometry and properties to be required fields (removed | None)

Copy link
Contributor

@tylanderson tylanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should opportunities model get the same treatment?

@philvarner
Copy link
Contributor Author

Looks good, should opportunities model get the same treatment?

Good point, possibly -- I think we'll have bigger changes to Opps as we start looking at it further.

@philvarner philvarner merged commit 5f873cd into main Dec 6, 2024
2 checks passed
@philvarner philvarner deleted the pv/subsume-Feature-into-Order branch December 6, 2024 17:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants