Skip to content
This repository was archived by the owner on Apr 2, 2025. It is now read-only.

use StrEnum and ResultE types #114

Merged
philvarner merged 1 commit into from
Dec 6, 2024
Merged

use StrEnum and ResultE types #114

philvarner merged 1 commit into from
Dec 6, 2024

Conversation

@philvarner
Copy link
Contributor

@philvarner philvarner commented Dec 5, 2024

Related Issue(s):

  • n/a

Proposed Changes:

  1. replace enums extending str, Enum with StrEnum
  2. replace Result[A, Exception] types with the alias ResultE[A]

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

trevorskaggs
trevorskaggs approved these changes Dec 6, 2024
View reviewed changes
Copy link

@trevorskaggs trevorskaggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@philvarner philvarner merged commit 490c526 into main Dec 6, 2024
2 checks passed
@philvarner philvarner deleted the pv/str-enum-and-resulte branch December 6, 2024 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tylanderson tylanderson Awaiting requested review from tylanderson

1 more reviewer

@trevorskaggs trevorskaggs trevorskaggs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philvarner @trevorskaggs