refactor(sierra): Removed unused param_idx parameter of AddConst. #9488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was unused before - thiis now changes the meaning in sierra crate to the existing meaning in sierra-generator crate. SIERRA_UPDATE_PATCH_CHANGE_TAG=No result effect.
|
This change is |
orizi
requested review from
TomerStarkware,
eytan-starkware,
ilyalesokhin-starkware and
liorgold2
eytan-starkware
approved these changes
Jan 18, 2026
Contributor
eytan-starkware
left a comment
eytan-starkware
left a comment
There was a problem hiding this comment.
@eytan-starkware reviewed 26 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware, @liorgold2, and @TomerStarkware).
TomerStarkware
approved these changes
Jan 18, 2026
Collaborator
TomerStarkware
left a comment
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed all commit messages and made 1 comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the
DeferredVariableKindenum by replacing it with the existingDeferredOutputKindfrom the Sierra library. This simplifies the codebase by eliminating duplicate enum definitions and standardizing on a single representation for deferred output types.Type of change
Please check one:
Why is this change needed?
The codebase had two separate enums (
DeferredVariableKindandDeferredOutputKind) representing the same concept. This duplication required mapping between the two types and maintaining parallel implementations. By using the existingDeferredOutputKindenum directly, we eliminate this redundancy and simplify the code.Additionally, the
AddConstvariant inDeferredOutputKindpreviously contained aparam_idxfield that wasn't actually being used in a meaningful way, so it was removed to further simplify the implementation.What was the behavior or documentation before?
Before this change, the code maintained two parallel enum types:
DeferredVariableKindin the store_variables moduleDeferredOutputKindin the sierra libraryThe code had to map between these types, and the
AddConstvariant inDeferredOutputKindcontained an unusedparam_idxfield.What is the behavior or documentation after?
After this change:
DeferredVariableKindhas been removed entirelyDeferredOutputKinddirectlyparam_idxfield has been removed from theAddConstvariant inDeferredOutputKindAdditional context
This refactoring doesn't change any functionality but makes the code more consistent and easier to maintain by eliminating duplicate type definitions and unnecessary fields.