starknet_os_runner: add RpcRunnerFactory for creating runners

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• starknet_os_runner: avoid panic in require bouncer lock #11763
• starknet_os_runner: small refactor in function names and doc #11760
• starknet_os_runner: avoid panic in unexpected relocatble value in a casm`s bytecode #11759
• starknet_os_runner: refactor crate visibility #11652
• starknet_os_runner: move block number and contract class manager to be fields of the runner #11651
• starknet_os_runner: add RpcRunnerFactory for creating runners #11581 👈 (View in Graphite)
• starknet_os_runner: fix async/sync boundary with spawn_blocking #11580
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[avi-starkware]

crates/starknet_os_runner/src/virtual_block_executor.rs line 259 at r1 (raw file):

    /// Whether transaction validation is enabled during execution.
    pub validate_txs: bool,
}

1. Why isn't pub(crate) sufficient here?
2. Consider making the fields rpc_state_reader and validate_txs private if possible

Code quote:

pub struct RpcVirtualBlockExecutor {
    /// The state reader for the virtual block executor.
    pub rpc_state_reader: RpcStateReader,
    /// Whether transaction validation is enabled during execution.
    pub validate_txs: bool,
}

[avi-starkware]

@avi-starkware reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware and @noaov1).

---

crates/starknet_os_runner/src/runner.rs line 267 at r1 (raw file):

///
/// let runner = factory.create_runner(BlockNumber(800000));
/// let output = runner.run_os(txs).await?;

run_os requires the block_number as input

Code quote:

/// let output = runner.run_os(txs).await?;

---

crates/starknet_os_runner/src/runner.rs line 292 at r1 (raw file):

    /// The runner is ready to execute transactions on top of the specified block.
    /// Each runner is single-use (consumed when `run_os` is called).
    pub fn create_runner(&self, block_number: BlockNumber) -> RpcRunner {

This could potentially create a mismatch with run_os if a different block_number is provided there than the number provided when creating the runner.

Code quote:

    pub fn create_runner(&self, block_number: BlockNumber) -> RpcRunner {

[avi-starkware]

@avi-starkware reviewed 1 file.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware and @noaov1).

[AvivYossef-starkware]

@AvivYossef-starkware made 3 comments.
Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @avi-starkware and @noaov1).

---

crates/starknet_os_runner/src/runner.rs line 267 at r1 (raw file):

Previously, avi-starkware (Avi Cohen) wrote…

run_os requires the block_number as input

Thanks

---

crates/starknet_os_runner/src/runner.rs line 292 at r1 (raw file):

Previously, avi-starkware (Avi Cohen) wrote…

This could potentially create a mismatch with run_os if a different block_number is provided there than the number provided when creating the runner.

see #11651 I think that its a better solution

---

crates/starknet_os_runner/src/virtual_block_executor.rs line 259 at r1 (raw file):

Previously, avi-starkware (Avi Cohen) wrote…

1. Why isn't pub(crate) sufficient here?
2. Consider making the fields rpc_state_reader and validate_txs private if possible

see #11652

[avi-starkware]

@avi-starkware reviewed 1 file and all commit messages, made 1 comment, and resolved 3 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1).