apollo_batcher: use genesis block hash for hash of block 0

[amosStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2026-01-13T09:23:59Z
• Started at 2026-01-13T10:32:54Z
• Started at 2026-01-13T10:33:44Z
• Started at 2026-01-13T10:34:54Z
• Started at 2026-01-13T12:14:12Z

[amosStarkware]

• apollo_rpc: use genesis parent hash in starknet api #11678
• apollo_state_sync, apoolo_central_sync: use genesis parent hash in starknet api #11675
• apollo_batcher: use genesis block hash for hash of block 0 #11660 👈 (View in Graphite)
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

@dorimedini-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @yoavGrs).

---

crates/starknet_api/src/block.rs line 281 at r2 (raw file):

impl BlockHash {
    // TODO(Amos): Use this anywhere the genesis block hash is used.
    pub const GENESIS: Self = Self(StarkHash::ZERO);

genesis block is block zero, which has a "real" hash; StarkHash::ZERO is the "hash of it's parent"

Suggestion:

pub const GENESIS_PARENT_HASH: Self = Self(StarkHash::ZERO);

[amosStarkware]

@amosStarkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @yoavGrs).

---

crates/starknet_api/src/block.rs line 281 at r2 (raw file):

Previously, dorimedini-starkware wrote…

genesis block is block zero, which has a "real" hash; StarkHash::ZERO is the "hash of it's parent"

are you sure?
here GENESIS_HASH is the hash of block -1

[dorimedini-starkware]

@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @yoavGrs).

---

crates/starknet_api/src/block.rs line 281 at r2 (raw file):

Previously, amosStarkware wrote…

are you sure?
here GENESIS_HASH is the hash of block -1

hmmm... seems misnamed there, IMO.
see here: "genesis hash" is the parent hash of the "first block hash".
genesis block is block zero.
I would rename here, maybe ask whoever wrote the original GENESIS_HASH constant if that' what they meant?
(also may be worth replacing all usages of the existing GENESIS_HASH with your new const

[dorimedini-starkware]

@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @yoavGrs).

---

crates/starknet_api/src/block.rs line 281 at r2 (raw file):

Previously, dorimedini-starkware wrote…

hmmm... seems misnamed there, IMO.
see here: "genesis hash" is the parent hash of the "first block hash".
genesis block is block zero.
I would rename here, maybe ask whoever wrote the original GENESIS_HASH constant if that' what they meant?
(also may be worth replacing all usages of the existing GENESIS_HASH with your new const

(not in this PR of course)

[amosStarkware]

@amosStarkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @yoavGrs).

---

crates/starknet_api/src/block.rs line 281 at r2 (raw file):

Previously, dorimedini-starkware wrote…

(not in this PR of course)

Done.

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs).