apollo_consensus_orchestrator: remove round 0 assertion. #11767
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
matanl-starkware
left a comment
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry).
-- commits line 2 at r1:
Please add more information to the commit message regarding the situation; it might happen that we start a new height with a round > 0.
Code quote:
remove round 0 assertion.
it might happen that we start a new height with a round > 0. e.g. if we already have enough Nil precommit votes cached for early rounds.
dafnamatsry
force-pushed
the
dafna/remove-round-zero-assert
branch
from
cb0af86 to
6dc7e78
Compare
dafnamatsry
left a comment
dafnamatsry
left a comment
There was a problem hiding this comment.
@dafnamatsry made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @dafnamatsry).
Previously, matanl-starkware (Matan Lior) wrote…
Please add more information to the commit message regarding the situation; it might happen that we start a new height with a round > 0.
Done.
matanl-starkware
left a comment
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed all commit messages.
Reviewable status:
No description provided.