Skip to content

Refactor label assignment in pickFormFields function. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vibranovsky wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor label assignment in pickFormFields function. #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/schema/lib/pickFormFields.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default function pickFormFields (schema, options) {
for (const key in schema) {
if (shouldIncludeField(key, schema[key], { include, exclude })) {
const field = schema[key]
if (!field.label) field.label = camelCaseToLabel(key)
if (field.label === undefined || field.label === null) field.label = camelCaseToLabel(key)
Copy link
Copy Markdown
Member

@cray0000 cray0000 Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (field.label === undefined || field.label === null) field.label = camelCaseToLabel(key)
if (field.label == null) field.label = camelCaseToLabel(key)

это устоявшийся способ проверить является ли undefined или null. И единственное допустимое использование слабого равно == в JS.

} else {
delete schema[key]
}
Expand Down