Fix issue 171: avoid double dispatch for wildcard event#9
Merged
gabewillen merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue boost-ext#171 where wildcard events (event<_>) were being dispatched twice - once for the wildcard handler and once for the anonymous event dispatch mechanism. The fix ensures that anonymous events, which are internal events used for automatic transitions, do not participate in wildcard event dispatch.
Changes:
- Added template specialization for
anonymousevents to bypass wildcard event dispatch logic - Added regression test to verify wildcard events are only fired once
- Registered the new test in the CMake build system
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| include/boost/sml.hpp | Added get_event_mapping_impl_helper specialization for anonymous to prevent double dispatch with wildcard events |
| test/ft/issue_171.cpp | Added regression test verifying wildcard events fire exactly once, not twice |
| test/ft/CMakeLists.txt | Registered the new test_issue_171 test executable and test case |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reference:
event<_>is invoked twice by one event boost-ext/sml#171