Update TargetFramework to net10.0 and bump all dependencies #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scaped. Probably due to changes in how the dotnet CLI or Spectre interprets arguments, computed metadata no longer needs to be contained within a set of escaped quotes.
Replaced string concatonation with string interlepolation in two tests and inverted left/right comparison in a further two tests. Amended logic appears to be Unit Test specific with no impact on Statiq code.
…longer available.
…ory.Build.props files.
… with Statiq.Web.
…e security issue.
…sues. Pin dependencies Newtonsoft.Json and System.Drawing.Common to resolve security issues.
Member
|
Thanks again for all the work on this! Merging it now and then going to work on bringing this code into the Statiq.Web repo (and archiving this one). |
Contributor
Author
If there's anything I can do to help please do reach out, happy to help where I can 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credits
Summary
netcoreapp3.1withnet10.0as the target framework for the solution.EPPlusremains at4.5.2.1due to the project becoming licensed after that versionJSPoolremains at2.0.1because upgrading breaks a Unit Test in Statiq.Web which I have been unable to successfully debug.Potential Breaks
InitializeLifetimeService()has been removed from theStreamclass with no migration path. This function has also been removed fromsrc/core/Statiq.Common/Util/ItemStreams/ItemStream{TItem}.csServicePointManagerno longer affectsHttpClient. Code removed fromsrc/core/Statiq.Core/Modules/IO/MirrorResources.cs. Working assumption is that valid SSL configurations are either present or easy enough to configure to warrant this removal. Further refactoring to manage an HttpClientFactory across the pipeline would be needed if this functionality is still required.tests/core/Statiq.App.Tests/Bootstrapper/BootstrapperFixture.cs.