Fix peerDependencies of `flow-bin` package by tyger · Pull Request #52 · stcheng/gulp-flowtype

tyger · 2017-07-31T09:48:38Z

SemVer behaviour is different in case major version of package is 0 (it's considered to be a pre-release version) so ^0.39.0 only corresponds to '0.39.0', which limits you from using any newer version of flow-bin. Required version is changed to allow all newer version up to 1.0

`SemVer` behaviour is different in case major version of package is 0 (it's considered to be a pre-release version) so `^0.39.0` only corresponds to '0.39.0', which limits you from using any newer version of `flow-bin`. Required version is changed to allow all newer version up to `1.0`

Fix peerDependencies of `flow-bin` package

Added `flow-bin` as devDependency in order to pass tests.

houndci-bot · 2017-07-31T21:00:49Z

test/main.js

-        should.equal(stringError, true);
-        should.equal(iterationError, true);
+        should.equal(stringError, true, 'Error with string type is not found.');
+        should.equal(iterationError, true, 'Error with interaction is not found.');


Line is too long.

houndci-bot · 2017-07-31T21:00:49Z

test/main.js

    if (/string/.test(arg)) stringError = true;
    if (/Required/.test(arg)) moduleError = true;
-    if (/iteration/.test(arg)) iterationError = true;
+    if (/must be an object/.test(arg)) iterationError = true;


Expected '{' and instead saw 'iterationError'.

…t execution

tyger · 2017-09-26T13:56:44Z

@charliedowler Any thoughts about ^^^?

houndci-bot · 2019-01-18T23:44:35Z

index.js


  return through.obj(Flow, function () {
-    var end = () => {
+    const end = () => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:44:35Z

index.js


    isFileSuitable(file).then(() => {
-      var hasPragma = hasJsxPragma(file.contents.toString());
+      const hasPragma = hasJsxPragma(file.contents.toString());


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:44:35Z

index.js

  function Flow(file, enc, callback) {

-    var _continue = () => {
+    const _continue = () => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:44:35Z

index.js

-  var defers = servers.map(function(_path) {
-    var deferred = Q.defer();
+  const defers = servers.map(function (_path) {
+    const deferred = Q.defer();


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:44:35Z

index.js

 function killServers() {
-  var defers = servers.map(function(_path) {
-    var deferred = Q.defer();
+  const defers = servers.map(function (_path) {


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:44:36Z

index.js

+  const stream = childProcess.spawn(getFlowBin(), args);

-  var dat = "";
+  let dat = '';


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:44:36Z

index.js

  ];

-  var stream = childProcess.spawn(getFlowBin(), args);
+  const stream = childProcess.spawn(getFlowBin(), args);


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:44:36Z

index.js

  })() : 'status';

-  var args = [
+  const args = [


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:44:36Z

index.js

+  const opts = optsToArgs(options);

-  var command = opts.length || options.killFlow ? (() => {
+  const command = opts.length || options.killFlow ? (() => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:44:37Z

index.js

+  const deferred = Q.defer();

-  var opts = optsToArgs(options);
+  const opts = optsToArgs(options);


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:46:53Z

index.js


 function executeFlow(_path, options) {
-  var deferred = Q.defer();
+  const deferred = Q.defer();


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:46:53Z

index.js


 function optsToArgs(opts) {
-  var args = [];
+  const args = [];


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:46:53Z

index.js

-var servers = [];
-var passed = true;
+const servers = [];
+let passed = true;


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:46:53Z

index.js

 */
-var servers = [];
-var passed = true;
+const servers = [];


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:46:53Z

index.js

+const logSymbols = require('log-symbols');
+const childProcess = require('child_process');
+//const chalk = require('chalk');
+const reporter = require('flow-reporter');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-01-18T23:46:54Z

index.js

-var chalk = require('chalk');
-var reporter = require('flow-reporter');
+const Q = require('q');
+const fs = require('fs');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'require' is not defined.

houndci-bot · 2019-01-18T23:46:54Z

index.js

-var childProcess = require('child_process');
-var chalk = require('chalk');
-var reporter = require('flow-reporter');
+const Q = require('q');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'require' is not defined.

houndci-bot · 2019-01-18T23:46:54Z

declarations/log-symbols.d.js

@@ -1,3 +1,4 @@
 declare module 'log-symbols' {
  declare var success : string;
+  declare var warning : string;


Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Unrecoverable syntax error. (60% scanned).

houndci-bot · 2019-01-18T23:46:54Z

declarations/gulp-util.d.js

@@ -1,4 +1,5 @@
 declare module "gulp-util" {
+  declare function beep(val:any, cb:any): void;


'function closure expressions' is only available in Mozilla JavaScript extensions (use moz option).
'val' is defined but never used.
Expected ')' to match '(' from line 2 and instead saw ':'.
Expected '}' to match '{' from line 1 and instead saw ':'.
Expected an assignment or function call and instead saw an expression.
Expected an identifier and instead saw ')'.
Expected an identifier and instead saw ','.
Expected an identifier and instead saw ';'.
Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function.
Label 'cb' on any statement.
Missing semicolon.

houndci-bot · 2019-01-18T23:46:54Z

declarations/child_process.d.js

 declare module 'child_process' {
-  declare function execFile(command: string, args: string[], callback: any) : void;
+
+    declare type child_process$execFileCallback = (error: ?child_process$Error, stdout: Buffer, stderr: Buffer) => void;


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'error' is defined but never used.
Expected ')' to match '{b}' from line 3 and instead saw ':'.
Expected '=>' and instead saw '?'.
Expected '}' to match '{' from line 1 and instead saw ':'.
Expected an assignment or function call and instead saw an expression.
Identifier 'child_process$Error' is not in camel case.
Identifier 'child_process$execFileCallback' is not in camel case.
Line is too long.
Missing semicolon.
Unrecoverable syntax error. (10% scanned).

tyger added 3 commits July 31, 2017 10:46

Merge pull request #1 from tyger/peerDependencies-fix

574b731

Fix peerDependencies of `flow-bin` package

Update package.json

17f1275

Added `flow-bin` as devDependency in order to pass tests.

houndci-bot reviewed Jul 31, 2017

View reviewed changes

Fix tests broken because of updating version of flow-bin used for tes…

c0e5fea

…t execution

tyger force-pushed the master branch from 37480cb to c0e5fea Compare July 31, 2017 21:24

houndci-bot reviewed Jan 18, 2019

View reviewed changes

tyger force-pushed the master branch from ee07f39 to d730852 Compare January 18, 2019 23:46

houndci-bot reviewed Jan 18, 2019

View reviewed changes

Babel version bump

6f7fd63

tyger force-pushed the master branch from d730852 to 6f7fd63 Compare January 18, 2019 23:48

tyger added 3 commits January 18, 2019 23:51

x

7eb5570

Ignores

bf5fe0b

Added targets for babel.

83bca19

		@@ -1,4 +1,5 @@
		declare module "gulp-util" {
		declare function beep(val:any, cb:any): void;

Comments

Conversation

tyger commented Jul 31, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tyger commented Sep 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants