Skip to content

feat: refactor isFloat16Array to use constructorName #9215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gururaj1512 wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −10
Draft

feat: refactor isFloat16Array to use constructorName #9215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions lib/node_modules/@stdlib/assert/is-float16array/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,12 @@
* limitations under the License.
*/

/* eslint-disable no-undef, stdlib/jsdoc-doctest */ // TODO: remove once `array/float16` added; consider refactoring similar to `assert/is-complex128array`

'use strict';

// MODULES //

var nativeClass = require( '@stdlib/utils/native-class' );


// VARIABLES //

var hasFloat16Array = ( typeof Float16Array === 'function' ); // eslint-disable-line stdlib/require-globals
var Float16Array = require( '@stdlib/array/float16' );

Check failure on line 23 in lib/node_modules/@stdlib/assert/is-float16array/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

cannot resolve module: "@stdlib/array/float16"
var constructorName = require( '@stdlib/utils/constructor-name' );


// MAIN //
Expand All @@ -50,8 +44,8 @@
*/
function isFloat16Array( value ) {
return (
( hasFloat16Array && value instanceof Float16Array ) || // eslint-disable-line stdlib/require-globals
nativeClass( value ) === '[object Float16Array]'
value instanceof Float16Array ||
constructorName( value ) === 'Float16Array'
);
}

Expand Down
Loading