chore(deps): bump directories 5 -> 6 #19
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,10 +2,12 @@ | |
| name = "easy_flash_daplink" | ||
| version = "0.2.0" | ||
| edition = "2021" | ||
| # Pinned to the highest MSRV among our direct deps (currently iced 0.13). | ||
| rust-version = "1.80" | ||
|
|
||
| [dependencies] | ||
| async-io = "2" | ||
| directories = "6" | ||
| iced = "0.13.1" | ||
|
Comment on lines
9
to
11
There was a problem hiding this comment.
Contributor
Author
|
||
| iced_aw = { version = "0.11.0", default-features = false, features = ["grid", "number_input", "tab_bar"] } | ||
| iced_fonts = { version = "0.1.1", features = [] } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping
directoriesto v6 can change the resolved data directory on Windows/macOS (per upstream’s platform path tightening). Since CI currently only runs on Ubuntu, consider adding at least a basic Windows/macOS build/smoke test (or explicitly documenting that Linux is the only supported platform) to avoid shipping a silent settings-location change on those platforms.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining the suggestion to revert to
directories = "5"— the whole point of this PR is to take the major bump (one of the held-back items from #16). The Win/Mac path-resolution tightening you mention is real but is upstream's call, not something to dodge by staying on 5 forever. Cross-platform smoke test in CI is a fair separate ask, tracked-worthy if you want me to file an issue. For Linux (the only platform actually shipped today via release.yaml) the path layout under~/.local/share/daplink-easyflash/is unchanged.