fix: JSON reports emit invalid NaN + O(n) rolling window#6
Merged
Conversation
- report_to_dict now sanitizes NaN/Inf metric_value to null, producing RFC 8259-compliant JSON readable by any parser (not just CPython). - RollingWindow uses collections.deque(maxlen=N) instead of list with pop(0), reducing per-step cost from O(window_size) to O(1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Invalid JSON output
When NaN detector fires,
save_json()emits bareNaNliterals — invalid per RFC 8259. Every non-Python JSON parser (JS, jq, Go, Rust) rejects the file.Fix: Sanitize
NaN/Inftonullinreport_to_dict().Performance: RollingWindow
list.pop(0)is O(n) — shifts all elements on every training step. Replaced withcollections.deque(maxlen=N)for O(1) append.Tests
All 220 tests pass.