Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1af82883a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| public var usesWeb: Bool { | ||
| self == .auto || self == .web | ||
| self == .web |
There was a problem hiding this comment.
On macOS CLI, CodexProviderDescriptor.resolveStrategies still returns [web, cli] for .auto, and CodexWebDashboardStrategy.isAvailable gates on context.sourceMode.usesWeb. With usesWeb now false for .auto, the web dashboard strategy becomes unavailable even though it’s first in the auto pipeline. This means the default codexbar usage on macOS can no longer fall back to the web dashboard when there are no local CLI sessions, and will fail after the CLI strategy errors instead of fetching web usage. If the intent is to relax Linux-only gating, consider keeping .auto as web-capable on macOS (or moving the check to OS-specific logic) so the existing auto workflow on macOS doesn’t regress.
Useful? React with 👍 / 👎.
|
Follow-up: reverted |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65a3613754
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if parsedSourceMode == .web { | ||
| Self.exit( | ||
| code: .failure, | ||
| message: "Error: --source web/auto is only supported on macOS.", |
There was a problem hiding this comment.
After this change, --source auto is intentionally supported on non-macOS, but the emitted runtime error still says --source web/auto is only supported on macOS. When a Linux user passes --source web, this message now gives incorrect guidance and implies that auto is also invalid, which conflicts with the new behavior and can mislead CLI automation/users troubleshooting source selection.
Useful? React with 👍 / 👎.
1 participant
What
--source autoas non-web so Linux doesn’t error out by default.--source webmacOS-only behavior unchanged.ProviderSourceMode.usesWeb.KIMI_AUTH_TOKEN(auto mode).Why
On Linux, the CLI defaults to
--source auto, but it was gated as a web-only mode and aborted before providers could use env/api/cli strategies (e.g., Kimi viaKIMI_AUTH_TOKEN).Testing
swift test