fix(kimi): swap UI labels to match usage data order#310
Open
ajaxjiang96 wants to merge 3 commits intosteipete:mainfrom
Open
fix(kimi): swap UI labels to match usage data order#310ajaxjiang96 wants to merge 3 commits intosteipete:mainfrom
ajaxjiang96 wants to merge 3 commits intosteipete:mainfrom
Conversation
Following the data swap in commit f14971a where rate limit became primary and weekly became secondary, update the UI labels to match: - sessionLabel (shown for primary): "Weekly" → "Rate Limit" - weeklyLabel (shown for secondary): "Rate Limit" → "Weekly" This ensures the UI displays: - "Rate Limit" label with rate limit data - "Weekly" label with weekly data Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 257ab7bd87
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
When rateLimitWindow is nil, set secondary to nil instead of weeklyWindow to prevent showing the same weekly metric twice under different labels. Before: - No rate limit → primary: weekly, secondary: weekly (duplicate) After: - No rate limit → primary: weekly, secondary: nil (correct) - Has rate limit → primary: rate limit, secondary: weekly (correct) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sessionLabelfrom "Weekly" to "Rate Limit"weeklyLabelfrom "Rate Limit" to "Weekly"Context
In commit f14971a, the Kimi usage data was swapped so that rate limit (session) became primary and weekly became secondary. However, the UI labels in
KimiProviderDescriptor.swiftwere not updated, causing:Changes
File:
Sources/CodexBarCore/Providers/Kimi/KimiProviderDescriptor.swiftsessionLabel: "Weekly"→sessionLabel: "Rate Limit"weeklyLabel: "Rate Limit"→weeklyLabel: "Weekly"Test plan