Skip to content

Stabilize PTY CI timing tests #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ratulsarna merged 1 commit into from
Feb 6, 2026
Merged

Stabilize PTY CI timing tests #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Tests/CodexBarTests/TTYCommandRunnerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ struct TTYCommandRunnerEnvTests {
binary: scriptURL.path,
send: "",
options: .init(
timeout: 3,
timeout: 6,
// Use LF for portability: some PTY/termios setups do not translate CR → NL for shell reads.
sendOnSubstrings: ["Do you trust the files in this folder?": "y\n"],
sendOnSubstrings: ["trust the files in this folder?": "y\n"],
stopOnSubstrings: ["accepted", "rejected"],
settleAfterStop: 0.1))

Expand All @@ -118,15 +118,18 @@ struct TTYCommandRunnerEnvTests {
try fm.setAttributes([.posixPermissions: 0o755], ofItemAtPath: scriptURL.path)

let runner = TTYCommandRunner()
let timeout: TimeInterval = 12
let scriptedSleep: TimeInterval = 10
let startedAt = Date()
let result = try runner.run(
binary: scriptURL.path,
send: "",
options: .init(timeout: 6, idleTimeout: 0.2))
options: .init(timeout: timeout, idleTimeout: 0.2))
let elapsed = Date().timeIntervalSince(startedAt)

#expect(result.text.contains("hello"))
#expect(elapsed < 3.0)
// CI runners can delay PTY scheduling/reads; assert we stop well before script completion.
#expect(elapsed < (scriptedSleep - 1.0))
}

@Test
Expand Down