feat(api): add GPT-5.6 Pro reasoning controls - #335
Conversation
405df91 to
3d4e484
Compare
|
Codex review: needs changes before merge. Reviewed July 31, 2026, 5:40 PM ET / 21:40 UTC. ClawSweeper reviewWhat this changesAdds GPT-5.6 Responses API reasoning-mode and reasoning-effort CLI controls, session persistence, API-route validation, documentation, and automated coverage. Merge readinessKeep this PR open: its terminal live-API proof is sufficient and current Priority: P2 Review scores
Verification
How this fits togetherOracle accepts CLI and persisted session options, resolves a provider route and model configuration, then sends a Responses API request and optionally tracks its background completion. User-level model overrides can replace the on-wire API model after the CLI alias has been selected. flowchart LR
A[CLI flags and saved session options] --> B[Run options]
B --> C[Provider route]
B --> D[Model configuration and user overrides]
C --> E[Reasoning option validation]
D --> E
E --> F[Responses API request]
F --> G[Background response session]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Resolve the effective API model before enforcing the GPT-5.6 reasoning contract, preserve supported gateway behavior, and add a persisted-override regression test that rejects incompatible on-wire targets before any request is sent. Do we have a high-confidence way to reproduce the issue? Yes—source inspection gives a high-confidence path: run Is this the best way to solve the issue? No—the current branch is not yet the safest implementation because its GPT-5.6 validation runs before the documented effective-model override path. Validating the resolved dispatch target and covering that persisted-config case is the narrow maintainable repair. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 68b8c51b0ee0. LabelsLabel justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (13 earlier review cycles; latest 8 shown)
|
3d4e484 to
b291cdf
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Summary
--reasoning-mode standard|profor GPT-5.6 Responses API runs--reasoning-effort none|low|medium|high|xhigh|maxfor the complete GPT-5.6 effort setreasoning: { mode: "pro", effort: "max" }without inventing a model slugWhy
GPT-5.6 Pro is a Responses API reasoning mode, not a separate model slug. Oracle previously exposed a fixed reasoning effort but had no CLI path for Pro mode or GPT-5.6's new
noneandmaxeffort levels. Inputs such asgpt-5.6-sol-procould also fall through model normalization instead of failing with actionable guidance.Mode and effort are independent:
standardandproare the complete GPT-5.6 mode enum, whilenone,low,medium,high,xhigh, andmaxare the complete GPT-5.6 effort enum. The OpenAI reasoning-mode guide documents this request shape.Validation
After rebasing onto
mainat68b8c51b:Live API proof
Validated against the real OpenAI Responses API on rebased head
b291cdf4:The synthetic smoke completed through Oracle's background create/retrieve path with
model: "gpt-5.6-sol"andreasoning: { mode: "pro", effort: "max" }. No API key or private runtime data is included.