fix(browser): recognize Sol Pro effort control - #340
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close this PR as superseded by #320. So I’m closing this here and keeping the remaining discussion on #320. Review detailsDo we have a high-confidence way to reproduce the issue? No high-confidence live reproduction was independently run in this review, but the source makes the failure path clear: a GPT-5.6 Sol model-button label containing Is this the best way to solve the issue? No. Recognizing a standalone Pro effort is the right direction, but the selected-state check must distinguish an effort pill from a model label before it can safely short-circuit selection. Security review: Security review cleared: The diff only refines existing in-page UI recognition and adds tests; no dependency, credential, permission, network, or supply-chain surface is introduced. AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against 6009d4ad167b. |
4086ae1 to
a21f29c
Compare
|
Maintainer repair Proof: focused thinking-time tests 27/27, |
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(browser): recognize Sol Pro effort control This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Summary
ChatGPT's current GPT-5.6 Sol composer exposes
Proas a separate reasoning-effort choice inside its combined intelligence menu. This change lets Oracle recognize and select that control when--browser-thinking-time heavyrequests the highest available effort.Problem
Oracle's browser engine runs JavaScript in the signed-in ChatGPT page to inspect the composer and choose a reasoning effort. Its GPT-5.6 path recognized the earlier
Extra highlabel and a dedicated Pro-effort trigger, but the current UI can instead present a genericProitem alongside a separateGPT-5.6 Solmodel item in one menu.In that layout, Oracle could report
option-not-foundeven when Pro was already selected, or fail to select Pro when another effort was active. This is separate from model selection: open PR #320 teaches Oracle to recognize theGPT-5.6 Solmodel item when the same menu also contains a Pro pill, while this PR handles the independent effort item after the model has been chosen.Implementation
heavyeffort only, treat a standaloneProitem in the intelligence-effort menu as the target effort.Protoken.GPTor a5.6model version when searching for the effort item, so the code does not mistake a model label for an effort.The test fixture models the current combined menu with separate model and effort entries. It covers both an already-selected Pro pill and switching an unchecked Pro radio item.
Live browser proof
I ran a signed-in ChatGPT browser smoke at commit
4086ae1298f0353ebc8649ce8656dcd1233095cewith the current UI:Relevant output:
The run completed in 18.3 seconds. No
Answer nowcontrol was clicked.Validation
pnpm checkpnpm vitest run tests/browser/thinkingTime.test.tspnpm run buildpnpm run test:packed-cliCompatibility and security
This change does not add a network endpoint, alter authentication, copy browser credentials, or change model selection. It only broadens recognition within the existing ChatGPT effort menu for the GPT-5.6
heavymapping.