chore: add pagination and root field linter rules#112
Merged
ddebrunner merged 1 commit intomainfrom Jul 15, 2025
Merged
Conversation
carloseberhardt
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a PR description for the changes:
�� Add non-nullable
firstargument requirement to GraphQL pagination lintingSummary
Updated the GraphQL linter's pagination argument types rule to require
Int!(non-nullable Int) for thefirstargument in pagination, enforcing better GraphQL API design patterns.Changes Made
🔧 Core Linter Updates
pagination-argument-typesrule to specifically check for non-nullableInttype forfirstargument'first' argument should be of type 'Int'to'first' argument should be of type 'Int!'�� Test Updates
should detect nullable first argument typeto verify nullableIntis flagged as errorInt!instead ofIntin valid examples📚 Documentation Updates
firstshould beInt!instead ofIntBehavior Changes
Before:
After:
Testing
Impact
This change enforces better GraphQL API design by requiring clients to always provide a limit value for pagination, preventing potential issues with undefined or null
firstarguments.Jaffa Cakes earned: 5 🍰