docs: overhaul README and CLI help with comprehensive feature documentation#92
Conversation
…tation - Rewrite README with full CLI reference table, feature details for column stripping, join stripping, aggressive mode, and join hints (including safety matrix), re-inlining support, output format, and library usage examples with InlinerOptions API - Add Library NuGet installation section and programmatic API examples - Improve CLI --help output: descriptive option text, usage examples, join hint syntax, and a pointer to SqlInliner.Library NuGet package https://claude.ai/code/session_01RtJtCDtKnm8VE7NwoAy2Fe
Summary of ChangesHello @stevehansen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's documentation and user experience by providing a thoroughly updated README and more informative CLI help. The changes aim to make the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request provides a significant overhaul of the project's documentation, including a comprehensive rewrite of the README.md file and improvements to the CLI's help output. The new README is well-structured, detailed, and includes valuable information on installation, CLI usage, feature details, and library integration. The CLI help text is also much more informative.
I've found one issue in a C# code example in the README that would cause it to fail at runtime. My feedback includes a correction for this example to ensure users of the library have a smooth experience.
The DatabaseConnection constructor immediately queries sys.views, so the connection should be explicitly opened first. https://claude.ai/code/session_01RtJtCDtKnm8VE7NwoAy2Fe
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add concrete before/after SQL example showing what inlining does - Add prerequisites section (requires .NET 8+ SDK) - Mention --help and --version in installation section - Document exit code behavior - Replace misleading "keep all joins" example with file+database combo - Fix SQL auth example to not use sa login - Clarify inliner.Sql vs Result.Sql vs Result.ConvertedSql in library docs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
column stripping, join stripping, aggressive mode, and join hints
(including safety matrix), re-inlining support, output format, and
library usage examples with InlinerOptions API
join hint syntax, and a pointer to SqlInliner.Library NuGet package
https://claude.ai/code/session_01RtJtCDtKnm8VE7NwoAy2Fe