also extract PDFs

[mayoff]

No description provided.

[steventroughtonsmith]

But PDFs in Asset Catalogs are converted to bitmaps at compile-time, no? Is there a case in the OS where this is not true? Can you provide an example?

[mayoff]

/Applications/Xcode.app/Contents/SharedFrameworks/DVTKit.framework/Resources/Assets.car (Xcode 7.3.1) has a bunch, which is why I wrote this patch.

[mayoff]

More generally, Xcode includes the PDF in Assets.car when building a Mac app, in addition to the generated PNGs.

[steventroughtonsmith]

Perfect, thanks! I'll need to do some work before I merge this as the current seeds seem to break things somewhat. No immediate ETA

[mayoff]

Yeah, I noticed it doesn't work on car files in Xcode 8b3.

[steventroughtonsmith]

Seems to be a locking issue, but not sure if I should fix it right now if it's just going to be a temporary bug in a few seeds or whatever. Will revisit closer to GM 👍

[getaaron]

@mayoff @steventroughtonsmith Wish I had seen this before I wrote #24.

Some elements from this PR are definitely more elegant than mine. I think you may need the [CUICatalog -initWithURL: error:] initializer I used in my PR to get PDFs out of the Assets.car file. It was crashing for me using the older CUIThemeFacet approach.