Skip to content

(Closes #2624) Add FortranWriter().schedule_node().#2628

Merged
sergisiso merged 7 commits intomasterfrom
2624_schedule_printing
Nov 29, 2024
Merged

(Closes #2624) Add FortranWriter().schedule_node().#2628
sergisiso merged 7 commits intomasterfrom
2624_schedule_printing

Conversation

@JulienRemy
Copy link
Collaborator

Avoids defaulting to str(schedule) for Schedule().debug_string() and raising a VisitorError using FortranWriter()(Schedule()).

@codecov
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (130eac0) to head (7b07110).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2628   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files         357      357           
  Lines       49708    49724   +16     
=======================================
+ Hits        49652    49668   +16     
  Misses         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JulienRemy JulienRemy changed the title (Closes #2624) Add Schedule().debug_string() and FortranWriter().schedule_node(). (Closes #2624) Add FortranWriter().schedule_node(). Jun 24, 2024
@JulienRemy
Copy link
Collaborator Author

@sergisiso This is a very minor feature but it's proven convenient at times. It should now be ready to merge if you want.

Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JulienRemy, this is a small PR that improves our debug_string capabilities, all checks are green. This is approved for merging.

Apologies that this was not reviewer earlier, in the future remember to put the "Ready for Review" label so I can see it marked on the list of PRs.

@sergisiso
Copy link
Collaborator

Waiting for #2775 for get merged

@sergisiso sergisiso merged commit 465f84e into master Nov 29, 2024
@sergisiso sergisiso deleted the 2624_schedule_printing branch November 29, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments