(Closes #2624) Add FortranWriter().schedule_node().#2628
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2628 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 357 357
Lines 49708 49724 +16
=======================================
+ Hits 49652 49668 +16
Misses 56 56 ☔ View full report in Codecov by Sentry. |
sergisiso
reviewed
Jun 21, 2024
…to `FortranWriter`.
Schedule().debug_string() and FortranWriter().schedule_node().FortranWriter().schedule_node().
Collaborator
Author
|
@sergisiso This is a very minor feature but it's proven convenient at times. It should now be ready to merge if you want. |
sergisiso
approved these changes
Nov 28, 2024
Collaborator
sergisiso
left a comment
There was a problem hiding this comment.
Thanks @JulienRemy, this is a small PR that improves our debug_string capabilities, all checks are green. This is approved for merging.
Apologies that this was not reviewer earlier, in the future remember to put the "Ready for Review" label so I can see it marked on the list of PRs.
Collaborator
|
Waiting for #2775 for get merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids defaulting to
str(schedule)forSchedule().debug_string()and raising aVisitorErrorusingFortranWriter()(Schedule()).