(closes #2981) Fixes for profile trans without the updates#3009
(closes #2981) Fixes for profile trans without the updates#3009
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3009 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 365 365
Lines 51930 51956 +26
=======================================
+ Hits 51886 51912 +26
Misses 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sergisiso
left a comment
There was a problem hiding this comment.
@LonelyCat124 See question below
sergisiso
left a comment
There was a problem hiding this comment.
@LonelyCat124 See comment below
|
@sergisiso ready for another look - only thing I'm not sure about is using |
sergisiso
left a comment
There was a problem hiding this comment.
Thanks @LonelyCat124 . This is getting closer, see inline comments. Is the PR still "towards" and not "closes"?
|
I think its towards as I'd like to leave the issue open until #3004 is ready to deal with the rest of the options updates. |
|
@sergisiso Ready for another look. |
sergisiso
left a comment
There was a problem hiding this comment.
@LonelyCat124 See some more comments below
|
I think this is ready for review again @sergisiso |
|
A quick note of encouragement - this PR fixes the issues I saw when attempting to profile NEMOv5 with Chris' sea-ice refactoring :-) |
sergisiso
left a comment
There was a problem hiding this comment.
Thanks for doing the changes @LonelyCat124, I like this implementation with the encapsulated "has_potential_control_flow_jump" much more, this is ready to merge.
I will close the issue and rename the other PR, as this already fully fixes the issue.
This is the small PR with just the functionality changes from #3004 .