(Closes #3032, #3031) updates to improve profiling#3033
Conversation
|
One for @sergisiso as he has a separate PR that brings profiling of NEMO into the integration tests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3033 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 365 365
Lines 51665 51671 +6
=======================================
+ Hits 51624 51630 +6
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Having improved the script, I immediately ran into more issues relating to #3031 so I'm going to fix those in this PR too. |
|
I've made what I think are the necessary changes to PSyDataTrans. |
|
@LonelyCat124 has pointed out that he already has #3004 so I don't have to worry about the |
|
Ready for a first look now. I've fired off the integration tests "just in case". |
sergisiso
left a comment
There was a problem hiding this comment.
@arporter I agree with the changes: not annotating with profiling wrappers elemental functions and removing the pure attribute of annotated routines. Also not annotating any function for NEMO as this have a big overhead. The integration tests are green, this is approved for merging.
No description provided.