Skip to content

(Closes #3032, #3031) updates to improve profiling#3033

Merged
sergisiso merged 12 commits intomasterfrom
3032_no_profile_cmp_fns
Jul 3, 2025
Merged

(Closes #3032, #3031) updates to improve profiling#3033
sergisiso merged 12 commits intomasterfrom
3032_no_profile_cmp_fns

Conversation

@arporter
Copy link
Member

No description provided.

@arporter arporter requested a review from sergisiso June 13, 2025 12:17
@arporter
Copy link
Member Author

One for @sergisiso as he has a separate PR that brings profiling of NEMO into the integration tests.

@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (c2ebc91) to head (4d580a4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3033   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         365      365           
  Lines       51665    51671    +6     
=======================================
+ Hits        51624    51630    +6     
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arporter arporter changed the title (Closes #3032) small update to improve NEMO profiling (Closes #3032, #3031) updates to improve profiling Jun 13, 2025
@arporter
Copy link
Member Author

Having improved the script, I immediately ran into more issues relating to #3031 so I'm going to fix those in this PR too.

@arporter arporter marked this pull request as draft June 13, 2025 14:31
@arporter
Copy link
Member Author

I've made what I think are the necessary changes to PSyDataTrans.
I need to add tests and update the options arguments...

@arporter
Copy link
Member Author

@LonelyCat124 has pointed out that he already has #3004 so I don't have to worry about the options here. Phew :-)

@arporter arporter marked this pull request as ready for review June 16, 2025 11:25
@arporter
Copy link
Member Author

Ready for a first look now. I've fired off the integration tests "just in case".

Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter I agree with the changes: not annotating with profiling wrappers elemental functions and removing the pure attribute of annotated routines. Also not annotating any function for NEMO as this have a big overhead. The integration tests are green, this is approved for merging.

@sergisiso sergisiso merged commit 68109b3 into master Jul 3, 2025
11 checks passed
@sergisiso sergisiso deleted the 3032_no_profile_cmp_fns branch July 3, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants