(towards #2971) move ACC loop trans and OMP parallel loop trans#3066
Open
victoria-atkinson wants to merge 9 commits intomasterfrom
Open
(towards #2971) move ACC loop trans and OMP parallel loop trans#3066victoria-atkinson wants to merge 9 commits intomasterfrom
victoria-atkinson wants to merge 9 commits intomasterfrom
Conversation
Member
|
Sorry to crash the party but I've just found a bug in def validate(self, node_list, options=None):
'''
Perform OpenMP-specific validation checks.
:param node_list: list of Nodes to put within parallel region.
:type node_list: list of :py:class:`psyclone.psyir.nodes.Node`
:param options: a dictionary with options for transformations.
:type options: Optional[Dict[str, Any]]
:param bool options["node-type-check"]: this flag controls if the \
type of the nodes enclosed in the region should be tested \
to avoid using unsupported nodes inside a region.
:raises TransformationError: if the target Nodes are already within \
some OMP parallel region.
'''
if node_list[0].ancestor(OMPDirective):
raise TransformationError("Error in OMPParallel transformation:" +
" cannot create an OpenMP PARALLEL " +
"region within another OpenMP region.")and thus we fall over if the supplied node_list = self.get_node_list(node_list)
if node_list[0].ancestor....We'd also need to add a new test that calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.