Updates to InlineTrans to support optional arguments

[schreiberx]

This PR would solve the issue #2525

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.90%. Comparing base (79fa6b6) to head (5f90b16).
⚠️ Report is 54 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3067   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files         376      376           
  Lines       52952    53044   +92     
=======================================
+ Hits        52900    52992   +92     
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[arporter]

Thanks very much Martin. It's exciting functionality. As agreed, I'm happy to push this on but could do with some input from you first. Could you take a look though and just answer the 'bigger' questions? I see that you've allowed the caller the option to provide a Routine to be inlined, rather than always rely on being able to find it. Is this to workaround cases where we are unable to work out which Routine is being called?

[schreiberx]

Thanks very much Martin. It's exciting functionality. As agreed, I'm happy to push this on but could do with some input from you first. Could you take a look though and just answer the 'bigger' questions? I see that you've allowed the caller the option to provide a Routine to be inlined, rather than always rely on being able to find it. Is this to workaround cases where we are unable to work out which Routine is being called?

It was originally intended just as a workaround to detect the right subroutine on my own and then inline this one.
I imagine this feature could still be useful, e.g., if the current detection of arguments fails (there are 1000ds of ways how it could fail...) and you still like to enforce it by providing the right one.

[arporter]

Thanks for the review @hiker, I think it's looking a lot better now. Ready for another look :-)

[hiker]

I was surprised that we don't have a more lengthy discussion of inlining in the documentation :)
Is looking good. I am waiting for the CI to finish, then I am ready to merge.

[hiker]

CI was green, no change was added since I ran it. I am waiting for git testing to finish, will then proceed to merge.

[hiker]

Happy to merge.