Skip to content

Acc kernel and utils file for NEMOv5#3130

Open
imaranresearch wants to merge 35 commits intomasterfrom
acc_ker_trans_sept
Open

Acc kernel and utils file for NEMOv5#3130
imaranresearch wants to merge 35 commits intomasterfrom
acc_ker_trans_sept

Conversation

@imaranresearch
Copy link
Collaborator

No description provided.

@imaranresearch
Copy link
Collaborator Author

@arporter Updated all the changes for comment logs. Ready for review.

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (2a1efa4) to head (d272c31).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3130   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         381      381           
  Lines       54015    54015           
=======================================
  Hits        53993    53993           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @imaranresearch. Well done for getting the diff back to a manageable size.
Mostly it's just a matter of tidying what you have.
I'll actually try running the integration test next time around.

@arporter
Copy link
Member

arporter commented Oct 2, 2025

Hi @imaranresearch, unfortunately, the new integration test failed:
https://github.com/stfc/PSyclone-mirror/actions/runs/18196318722/job/51803343216#step:16:38
It looks as though it's a simple matter of a path not quite matching what is expected - have a close look at the other NEMO jobs to see what's different.

@sergisiso
Copy link
Collaborator

I guess we need to add a baseline figure somewhere to get the relative slowdown plot to work for the new series?

@arporter @imaranresearch I forgot to mention that I added this during the holidays, so it will appear from now on.

@arporter
Copy link
Member

arporter commented Feb 6, 2026

Hi @imaranresearch, I've just had a look and I still see ArrayReference at L234:
image
Perhaps you haven't pushed your change? Once you're happy, please set the 'ready for review' label.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Imaran.
I'll re-run the ITs one final time.

@arporter
Copy link
Member

The integration test fails in one of the SI3 files :-(

NVFORTRAN-S-0155-Compiler failed to translate accelerator region (see -Minfo messages): Unknown variable reference (/archive/psyclone-tests/latest-run/UKMO-NEMOv5/tests/BENCH_ACC_KERNELS_OFFLOAD_NVHPC/BLD_SCT_PSYCLONE/obj/icedyn_adv_umx.f90: 775)
NVFORTRAN-F-0704-Compilation aborted due to previous errors. (/archive/psyclone-tests/latest-run/UKMO-NEMOv5/tests/BENCH_ACC_KERNELS_OFFLOAD_NVHPC/BLD_SCT_PSYCLONE/obj/icedyn_adv_umx.f90)
NVFORTRAN/x86-64 Linux 26.1-0: compilation aborted

@arporter
Copy link
Member

Hi @imaranresearch, I've taken the liberty of tidying the PR up but unfortunately the integration test fails. Would you like Sergi or I to take this on or are you still happy to do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants