Acc kernel and utils file for NEMOv5#3130
Conversation
|
@arporter Updated all the changes for comment logs. Ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3130 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 381 381
Lines 54015 54015
=======================================
Hits 53993 53993
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arporter
left a comment
There was a problem hiding this comment.
Thanks @imaranresearch. Well done for getting the diff back to a manageable size.
Mostly it's just a matter of tidying what you have.
I'll actually try running the integration test next time around.
|
Hi @imaranresearch, unfortunately, the new integration test failed: |
@arporter @imaranresearch I forgot to mention that I added this during the holidays, so it will appear from now on. |
|
Hi @imaranresearch, I've just had a look and I still see ArrayReference at L234: |
arporter
left a comment
There was a problem hiding this comment.
Thanks Imaran.
I'll re-run the ITs one final time.
|
The integration test fails in one of the SI3 files :-( |
|
Hi @imaranresearch, I've taken the liberty of tidying the PR up but unfortunately the integration test fails. Would you like Sergi or I to take this on or are you still happy to do it? |

No description provided.