(closes #2951) Consider dependencies in ArrayAssignment2LoopTrans

[sergisiso]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (c43bf3b) to head (e72ab2e).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3296   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         382      382           
  Lines       54077    54094   +17     
=======================================
+ Hits        54055    54072   +17     
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sergisiso]

@arporter @LonelyCat124 This is ready for a first review. In addition to preventing ArrayAssingment2Loop to be tripped by possible dependencies, it also adds kwargs to the transformation, takes advantage of the new Reference2ArrayRange behaviour for the validation, enables some valid range nesting, and fixes and issue in get_effective_shape.

[arporter]

Nice Sergi, it's a good improvement. Just a little bit of tidying required and I have a question about why the SIR-related changes have happened.

[sergisiso]

@arporter this is ready for another review. I triggered the ITs.

[arporter]

Almost there. There are a couple of bits I still don't fully understand. There's also the pesky SIR example - it would be worth checking what happens with that on master.
If it's a real problem we could just remove the part that attempts to generate SIR for the tracer-advection benchmark code.

[sergisiso]

@arporter This is ready for another review, I reverted and ignored the SIR problem as suggested

[arporter]

All looks good now, thanks Sergi. Just to be on the safe side I've set the ITs going again.
Once they're done, I'll proceed to merge.