Add profiling option for wrapping ROCTx#3317
Add profiling option for wrapping ROCTx#3317thomasgibson wants to merge 3 commits intostfc:masterfrom
Conversation
|
Exciting - I've approved the workflows to run for you. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3317 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 381 381
Lines 53995 53995
=======================================
Hits 53973 53973
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Nice job @thomasgibson - thanks for the README in particular. I've built the wrapper library without problems but haven't tried using it yet (@LonelyCat124 may want to try it too). If you could update the user-guide (https://psyclone.readthedocs.io/en/latest/user_guide/profiling.html#interface-to-third-party-profiling-tools) as part of your PR that would be great (PSyclone/doc/user_guide/profiling.rst). In fact, if you grep for nvidia in the various rst files, there may be other places you'll want to update too. |
|
Have just tried |
Thank you for pointing this out! I can certainly go through and make sure the existing documentation is up-to-date.
Excellent! I did try this with the tracer advection benchmark and was able to see the marker injections. Also do you think the Makefile as currently written needs some adjustment? If so, I'm happy to update it. For example, I use |
I nearly suggested that but then thought it might be a bit cheeky. Feel free to generalise/update it so that it can work with amd too. (e.g. some of the variables could be re-named and need |
This PR introduces Fortran interfaces for wrapping ROCTx, allowing for instrumenting Fortran codes for trace visualization on AMD GPUs. I have tested this using the
tra_adv.f90example so far, but still experimenting with it.Want to create this so others can try this out and review