Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3319 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 382 382
Lines 54049 54075 +26
=======================================
+ Hits 54027 54053 +26
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
IT triggered. Assuming this is green, this is ready to go. |
|
CI passed. I don't understand the missing coverage, clicking on the link indicates that my coverage is 100% (actually plus 0.10% for conftest.py)?? There is also a note that different coverage data are uploaded. Not sure what to do ... so I hope the review will enlighten me :) |
|
OK, the previously failing test now passed. I've re-triggered the CI (due to changes on master) |
|
I also added |
|
IT passed, ready for next review |
arporter
left a comment
There was a problem hiding this comment.
Great stuff Joerg, thanks for all that tidying. I think you get a gold star :-)
I'll proceed to merge.
Fixes #3318.
This affects a lot of tests, since the used testing method depends if there is a handler available for the python logger or not - so depending on test order they would fail. I have added an auto-use fixture to setup the logging the way it is in
generate.py, which results in consistent testing behaviour.