Skip to content

3318 dont set python root logger#3319

Merged
arporter merged 11 commits intomasterfrom
3318_dont_set_python_root_logger
Feb 17, 2026
Merged

3318 dont set python root logger#3319
arporter merged 11 commits intomasterfrom
3318_dont_set_python_root_logger

Conversation

@hiker
Copy link
Collaborator

@hiker hiker commented Feb 5, 2026

Fixes #3318.

This affects a lot of tests, since the used testing method depends if there is a handler available for the python logger or not - so depending on test order they would fail. I have added an auto-use fixture to setup the logging the way it is in generate.py, which results in consistent testing behaviour.

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (dbbb301) to head (05877ab).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3319   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         382      382           
  Lines       54049    54075   +26     
=======================================
+ Hits        54027    54053   +26     
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hiker
Copy link
Collaborator Author

hiker commented Feb 5, 2026

IT triggered. Assuming this is green, this is ready to go.

@hiker
Copy link
Collaborator Author

hiker commented Feb 10, 2026

CI passed. I don't understand the missing coverage, clicking on the link indicates that my coverage is 100% (actually plus 0.10% for conftest.py)?? There is also a note that different coverage data are uploaded. Not sure what to do ... so I hope the review will enlighten me :)

@hiker
Copy link
Collaborator Author

hiker commented Feb 11, 2026

OK, the previously failing test now passed. I've re-triggered the CI (due to changes on master)

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hiker for fixing this quite subtle issue. Logging seems to keep biting us.
Just small bits of tidying required.

@hiker
Copy link
Collaborator Author

hiker commented Feb 16, 2026

I also added TEST_LOGGER (two different ones) to omp_directives_test.py. Then I went over board when I saw the pylint warnings, and cleaned up the file (except for 'too many statements:) ). I also usedget_invoke` and replaced all old-style path assembly ... sorry, I just couldn't stop myself.

@hiker
Copy link
Collaborator Author

hiker commented Feb 16, 2026

IT passed, ready for next review

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff Joerg, thanks for all that tidying. I think you get a gold star :-)
I'll proceed to merge.

@arporter arporter merged commit 9b45306 into master Feb 17, 2026
15 checks passed
@arporter arporter deleted the 3318_dont_set_python_root_logger branch February 17, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PSyclone sets log level for root logger, not the PSyclone logger

2 participants