(closes #1651) Fix Reference2ArrayRange issue with capitalisations and test nested WHEREs#3338
(closes #1651) Fix Reference2ArrayRange issue with capitalisations and test nested WHEREs#3338
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3338 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 382 382
Lines 54094 54107 +13
=======================================
+ Hits 54072 54085 +13
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arporter
left a comment
arporter
left a comment
There was a problem hiding this comment.
Thanks Sergi. Just a couple of requests to add compilation to tests, where possible.
Issue number isn't mentioned anywhere.
I've grep'd and it doesn't look like any of the examples need updating.
I'll check the ITs next time.
| assert ("WHERE not supported because 'p_dal' cannot be converted to an " | ||
| "array due to: Transformation Error: The supplied node should be " | ||
| "a Reference to a symbol of known type, but 'p_dal%D12(:,:,1)' is" | ||
| " 'UnresolvedType'. Consider adding the declaration's filename " |
There was a problem hiding this comment.
Perhaps it's not this PR but "...adding the name of the file containing the declaration of this quantity to ..."
|
|
||
| # If enough information is provided, both WHEREs are resolved and nested | ||
| code = ("module my_mod\n" | ||
| " use some_mod\n" |
There was a problem hiding this comment.
Does this test need the use some_mod because if not, we could test compilation of the generated code?
There was a problem hiding this comment.
Done. I can remove it if I add the remaining symbol declarations (which in turn simplified the output code since it now has known bounds)
| array_of_ref(1:10)%field_of_fields(1)%inner = 1""" | ||
| assert expected_modified in output | ||
| assert expected_modified in output.lower() | ||
|
|
There was a problem hiding this comment.
Please add a compilation test.
2 participants
The generated code is a mouthful, but the reported issue with nested WHEREs is now fixed.