(Closes #3334) Make module-inlining mandatory for Kernel transformations#3388
(Closes #3334) Make module-inlining mandatory for Kernel transformations#3388
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3388 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 388 389 +1
Lines 54507 54377 -130
==========================================
- Hits 54485 54355 -130
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ITs were all green and coverage is now OK. Ready for a first review from @hiker, @LonelyCat124 or @sergisiso. |
|
I got worried that the previous PR which still had several open comments ended saying it was merged: But what happened is that those commits were part of the Anyway I've checked that the comments I made in the previous PR are now addressed or ported to the new review. |
|
Ready for another look now, I've just fired-off the ITs again. |
sergisiso
left a comment
There was a problem hiding this comment.
@arporter All comments have been addressed and the integration test pass. I could not find more mentions of the old functionallity. Thanks for the multiple takes on this, it's a good simplification of the codebase and the documentation.

A second attempt at this after my git fu let me down badly.
Original changes are here: https://github.com/stfc/PSyclone/pull/3294/changes#diff-436bf7f3b5f30b4c1d6ff1f9a0a8e144f924bae78cbcc9595b30fc5954e715e0