Skip to content

added .not. support for sympy#3394

Merged
hiker merged 4 commits into
masterfrom
martin_sym_not
Apr 8, 2026
Merged

added .not. support for sympy#3394
hiker merged 4 commits into
masterfrom
martin_sym_not

Conversation

@schreiberx
Copy link
Copy Markdown
Collaborator

This adds .not. support for sympy.

@schreiberx schreiberx requested a review from hiker April 2, 2026 15:16
@schreiberx schreiberx self-assigned this Apr 2, 2026
@schreiberx schreiberx requested review from arporter and removed request for hiker April 2, 2026 15:16
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (93d5826) to head (1ed9edb).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3394   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         387      387           
  Lines       54310    54317    +7     
=======================================
+ Hits        54288    54295    +7     
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hiker hiker requested review from hiker and removed request for arporter April 7, 2026 13:17
Copy link
Copy Markdown
Collaborator

@hiker hiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Martin, thanks a lot for fixing this (embarrassing that I've missed the .not.). A small code simplification, and a missing test to cover all lines is all, otherwise it's good to go.

Comment thread src/psyclone/psyir/backend/sympy_writer.py Outdated
Comment thread src/psyclone/psyir/backend/sympy_writer.py Outdated
Comment thread src/psyclone/psyir/backend/sympy_writer.py
@schreiberx
Copy link
Copy Markdown
Collaborator Author

... (embarrassing that I've missed the .not.).

It's not embarrassing, it was great work you did, just missing something small :-) !

Ready for next review round.

@hiker
Copy link
Copy Markdown
Collaborator

hiker commented Apr 7, 2026

Looking good, I've triggered the IT.

@hiker hiker removed the under review label Apr 8, 2026
Copy link
Copy Markdown
Collaborator

@hiker hiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IT were green, all comments addressed. Waiting for github tests to finish before proceeding to merge.

@hiker hiker merged commit a8f288e into master Apr 8, 2026
15 checks passed
@hiker hiker deleted the martin_sym_not branch April 8, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants