added .not. support for sympy#3394
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3394 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 387 387
Lines 54310 54317 +7
=======================================
+ Hits 54288 54295 +7
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hiker
left a comment
There was a problem hiding this comment.
Hi Martin, thanks a lot for fixing this (embarrassing that I've missed the .not.). A small code simplification, and a missing test to cover all lines is all, otherwise it's good to go.
It's not embarrassing, it was great work you did, just missing something small :-) ! Ready for next review round. |
|
Looking good, I've triggered the IT. |
hiker
left a comment
There was a problem hiding this comment.
IT were green, all comments addressed. Waiting for github tests to finish before proceeding to merge.
This adds .not. support for sympy.