Skip to content

(towards #1658) Use all intrinsic reduction expansion transformations in NEMO#3396

Merged
LonelyCat124 merged 10 commits intomasterfrom
nemo_expand_all_reduction_intr
Apr 21, 2026
Merged

(towards #1658) Use all intrinsic reduction expansion transformations in NEMO#3396
LonelyCat124 merged 10 commits intomasterfrom
nemo_expand_all_reduction_intr

Conversation

@sergisiso
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (bf74b74) to head (9a3d5b8).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3396   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         390      390           
  Lines       54558    54563    +5     
=======================================
+ Hits        54538    54544    +6     
+ Misses         20       19    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso
Copy link
Copy Markdown
Collaborator Author

This is ready for review. Maybe one for @LonelyCat124 as this removes some of the SUM intrinsics that we talked in another PR and fixes problems that I found with intrinsic_call return_type calculations when unknown information is involved.

Copy link
Copy Markdown
Collaborator

@LonelyCat124 LonelyCat124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sergisiso - Couple of small changes to do from the changes to IntrinsicCall in the docs, and there was a random TODO adjacent to some code you touched which no longer has an open corresponding issue so asked if you can check its relevance.

Comment thread src/psyclone/psyir/nodes/intrinsic_call.py
Comment thread src/psyclone/psyir/tools/dependency_tools.py Outdated
@sergisiso sergisiso changed the title Use all intrinsic reduction expansion transformations in NEMO (towards #1658) Use all intrinsic reduction expansion transformations in NEMO Apr 10, 2026
@sergisiso
Copy link
Copy Markdown
Collaborator Author

@LonelyCat124 This is ready for another review. I made this PR towards #1658 as it is related. Now we attempt to do it, but it is not fully solved yet as many still fail (gracefully - adding the error as a comment).

Comment thread src/psyclone/psyir/nodes/intrinsic_call.py Outdated
Comment thread src/psyclone/psyir/nodes/intrinsic_call.py Outdated
Copy link
Copy Markdown
Collaborator

@LonelyCat124 LonelyCat124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm going to fix the last minor docstring things and proceed to merge once the ITs are done.

@LonelyCat124 LonelyCat124 merged commit 31a7191 into master Apr 21, 2026
14 of 15 checks passed
@LonelyCat124 LonelyCat124 deleted the nemo_expand_all_reduction_intr branch April 21, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants