(towards #1658) Use all intrinsic reduction expansion transformations in NEMO#3396
(towards #1658) Use all intrinsic reduction expansion transformations in NEMO#3396LonelyCat124 merged 10 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3396 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 390 390
Lines 54558 54563 +5
=======================================
+ Hits 54538 54544 +6
+ Misses 20 19 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is ready for review. Maybe one for @LonelyCat124 as this removes some of the SUM intrinsics that we talked in another PR and fixes problems that I found with intrinsic_call return_type calculations when unknown information is involved. |
LonelyCat124
left a comment
There was a problem hiding this comment.
Hi @sergisiso - Couple of small changes to do from the changes to IntrinsicCall in the docs, and there was a random TODO adjacent to some code you touched which no longer has an open corresponding issue so asked if you can check its relevance.
|
@LonelyCat124 This is ready for another review. I made this PR towards #1658 as it is related. Now we attempt to do it, but it is not fully solved yet as many still fail (gracefully - adding the error as a comment). |
LonelyCat124
left a comment
There was a problem hiding this comment.
Looks good, I'm going to fix the last minor docstring things and proceed to merge once the ITs are done.
No description provided.