(Closes #2812) max and min code update

[LonelyCat124]

Small PR to ensure the max2code and min2code transformations use the datatype of their arguments correctly, and don't assume scalar real.

Ready for review from @arporter when he's back - its possible I missed something I should have added but I'm not sure.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (ddc5397) to head (0ad4e11).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3408   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         389      389           
  Lines       54541    54548    +7     
=======================================
+ Hits        54522    54529    +7     
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[arporter]

Nice, thanks Aidan. Just a bit of docstring tidying to do and there's a (simple) test failure that needs fixing. Once you've done that, please could you launch the ITs too...

[LonelyCat124]

Am hoping the test will just work this time as I'm a bit confused as I can't replicate it locally (any more). If not I'll dive deeper.

[LonelyCat124]

@arporter I have "fixed" the tree sitter issues now I think. I would ask if you could test locally as well and check you have no issues with your local version. I'm not sure why these tests have suddenly started failing, I tried running on another branch as well and they also have failures that weren't present last week. As far as I can find there has been no treesitter or treesitter-fortarn new release so its very strange.

[arporter]

Hi @LonelyCat124, I've just tried locally (with 3.13) and I get one treesitter-related failure with this branch. If I switch to latest master it goes away. It could be something to do with tests leaking state?

[LonelyCat124]

Set the ITs going - assume they are successful this is ready for another look.

[arporter]

ITs were all green and tests were fine (apart from a link-check on Tau which has an out-of-date certificate).
I was going to green-light it this time but then thought we should perhaps do the test skipping for tree sitter in a nicer fashion - see inline.

[LonelyCat124]

@arporter Created something in tests.utilities to do this and use that now.

[arporter]

Nice, thanks for that Aidan. All good now.