(closes #3411) Remove OpenMP SUB reduction operator (use ADD instead)#3413
Merged
Conversation
…syir binary operations
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3413 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 389 389
Lines 54542 54541 -1
=======================================
- Hits 54523 54522 -1
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sergisiso
requested review from
LonelyCat124 and
arporter
and removed request for
arporter
Collaborator
Author
|
@LonelyCat124 @arporter This should be ready for review. I launched the integration test to see if the other compilers also agree. |
LonelyCat124
approved these changes
Apr 23, 2026
Collaborator
LonelyCat124
left a comment
LonelyCat124
left a comment
There was a problem hiding this comment.
Looks good to me, simple fix, assuming ITs are ok will merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.