(towards #3279) Improves NEMOv5 performance#3414
Merged
Merged
Conversation
Collaborator
Author
|
@LonelyCat124 @arporter This is ready for review. It provides a small performance improvement over all NEMOv5 GPU targets and increases the script coverage, which is useful for testing purposes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3414 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 389 389
Lines 54541 54541
=======================================
Hits 54522 54522
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LonelyCat124
approved these changes
Apr 24, 2026
Collaborator
LonelyCat124
left a comment
There was a problem hiding this comment.
Yeah if they work for the integration tests without performance issues then this all looks fine, will proceed to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... by removing exclusions that don't need to be there anymore (no signal 11 observed), and avoid doing the lbclnk which has lots of small control loops on the GPU.