Skip to content

(towards #3279) Improves NEMOv5 performance#3414

Merged
LonelyCat124 merged 9 commits into
masterfrom
nemo_remove_singal11
Apr 24, 2026
Merged

(towards #3279) Improves NEMOv5 performance#3414
LonelyCat124 merged 9 commits into
masterfrom
nemo_remove_singal11

Conversation

@sergisiso
Copy link
Copy Markdown
Collaborator

... by removing exclusions that don't need to be there anymore (no signal 11 observed), and avoid doing the lbclnk which has lots of small control loops on the GPU.

@sergisiso sergisiso self-assigned this Apr 23, 2026
@sergisiso
Copy link
Copy Markdown
Collaborator Author

@LonelyCat124 @arporter This is ready for review. It provides a small performance improvement over all NEMOv5 GPU targets and increases the script coverage, which is useful for testing purposes.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (bb3e031) to head (8b3e235).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3414   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         389      389           
  Lines       54541    54541           
=======================================
  Hits        54522    54522           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@LonelyCat124 LonelyCat124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah if they work for the integration tests without performance issues then this all looks fine, will proceed to merge.

@LonelyCat124 LonelyCat124 merged commit ddc5397 into master Apr 24, 2026
14 of 15 checks passed
@LonelyCat124 LonelyCat124 deleted the nemo_remove_singal11 branch April 24, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants