Conversation
07dc2c0 to
6b347b1
Compare
ElliottKasoar
left a comment
There was a problem hiding this comment.
Can you add a list of things left to do e.g. if you add a space in between the square brackets below, it'll create a checkbox
- [] Update README
The developer guide may be slightly outdated in terms of what it suggests in terms of documenting a few model, but the main places will be the README and the user guide in docs.
We also need single point tests
| # Set before loading model to avoid type mismatches | ||
| torch.set_default_dtype(torch.float32) | ||
|
|
||
| # Default to MATPES-r2SCAN model |
There was a problem hiding this comment.
This doesn't seem to really be setting a default in the same way as this would normally mean, i.e. that this is automatically downloaded/used, not just a default string?
There was a problem hiding this comment.
I think AlphaNet doesn't call [torch.set_default_dtype()] internally, it sets [self.precision = torch.float32] but doesn't change the global default dtype?
|
Progress;
To do list
Final check
Documenting new model (check dev guide):
|
Co-authored-by: Elliott Kasoar <45317199+ElliottKasoar@users.noreply.github.com>
closes: #590