Use number of fip also for internal network#428
Merged
jose-caballero merged 3 commits intomainfrom Feb 10, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 109 109
Lines 2640 2643 +3
Branches 331 331
=======================================
+ Hits 2635 2638 +3
Misses 4 4
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jose-caballero
force-pushed
the
use_number_of_fip_also_for_internal_network
branch
from
76e7b83 to
4af85dd
Compare
gmatthews20
previously requested changes
Feb 6, 2026
Use the number of FIPs specified in the user form for both the Externals and the Internals Networks, and always override the default value. For that, the FIP creation process has been moved before checking which type of network is involved.
jose-caballero
force-pushed
the
use_number_of_fip_also_for_internal_network
branch
from
4af85dd to
90181dd
Compare
khalford
previously approved these changes
Feb 9, 2026
khalford
reviewed
Feb 9, 2026
We unconditionally allocate all the FIPs, whether they are going to be used or not. That's a waste of resources. Users can allocate the FIPs themselves when they are actually needed.
jose-caballero
force-pushed
the
use_number_of_fip_also_for_internal_network
branch
from
90181dd to
3ffaa4f
Compare
khalford
approved these changes
Feb 9, 2026
jose-caballero
dismissed
gmatthews20’s stale review
ghost request for changes is blocking merge
jose-caballero
deleted the
use_number_of_fip_also_for_internal_network
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?