Fix macOS BLE peripheral reconnection after sleep/wake#54
Fix macOS BLE peripheral reconnection after sleep/wake#54eonicum wants to merge 1 commit intostoprocent:mainfrom
Conversation
|
Thanks for taking the time to submit this PR! However, I can't merge it in its current state. There are a couple of issues that need to be addressed:
I'm definitely open to merging a fix for this issue, but it needs to meet our code quality standards and not introduce regressions elsewhere. Would you be able to revise the PR to address these points? Happy to discuss the approach if you'd like to chat about the best way forward. |
|
Sorry for the confusion with the PR. I just wanted to show what works for this issue. I should’ve made it clearer in the PR that this is only a proof of concept, not production-ready code (I mentioned it here #23 (comment), but not in the PR, sorry). Unfortunately, I don’t have much time till the end of the year to work on a proper fix, but I’m happy to help with testing or answer any questions if you need. Thanks for understanding! |
1ffce1e to
b783ba8
Compare
b783ba8 to
42c4d6d
Compare
No description provided.