Sco 2022 implement reusable audience csv export servicecontroller in#106
Open
timosville wants to merge 25 commits intomainfrom
Open
Sco 2022 implement reusable audience csv export servicecontroller in#106timosville wants to merge 25 commits intomainfrom
timosville wants to merge 25 commits intomainfrom
Conversation
…ders in CSV export
Deploying kit with
|
| Latest commit: |
c175f7b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://245a7588.kit-atq.pages.dev |
| Branch Preview URL: | https://sco-2022-implement-reusable.kit-atq.pages.dev |
JannieT
reviewed
Mar 23, 2026
Member
JannieT
left a comment
JannieT
left a comment
There was a problem hiding this comment.
Looking great so far Timothy!
…dynamic filename handling
…er identification
…in audiences index
…es index component
JannieT
requested changes
Mar 24, 2026
Member
JannieT
left a comment
JannieT
left a comment
There was a problem hiding this comment.
Very good improvements Timothy. Let's move the goal posts and make it even more scalable to handle thousands of users. I have left some suggestions for this.
…dienceService and update frontend to support dynamic loading
…empty values more gracefully
…ort-servicecontroller-in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we wait for the design for the export button.