Implement PartialEq, Eq on error enums - #638
Open
deadbaed wants to merge 1 commit into
Open
Conversation
The biggest change was to move the `io::Error` variants to `io::ErrorKind`, and keep original error messages as strings. Some manual `Clone` impls were moved to `#[derive(Clone)]`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The biggest change was to move the
io::Errorvariants toio::ErrorKind, and keep original error messages as strings.Some manual
Cloneimpls were moved to#[derive(Clone)]Context
The motivation is for a project I am working on using rage, and I need
PartialEqfor tests. I initially only needed for{Encrypt,Decrypt}Error, but I thought while I was at it, let's have all error enums havePartialEqandEq.