fix(rss): prevent path traversal via unvalidated feed_id in get_feed_file_path#451
Merged
poshinchen merged 1 commit intostrands-agents:mainfrom Apr 15, 2026
Merged
Conversation
mkmeral
previously approved these changes
Apr 15, 2026
mkmeral
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What
Fix CWE-22 path traversal vulnerability in the RSS tool's
get_feed_file_path()method.The
feed_idparameter was concatenated directly into a file path viaos.path.join(self.storage_path, f"{feed_id}.json")without validation, allowing traversal sequences like../to read, write, or delete.jsonfiles outside the intended storage directory.Fix
The fix resolves the constructed path with
os.path.realpath()and verifies it remains withinstorage_pathbefore returning. This covers all three affected operations (read viaload_feed_data, write viasave_feed_data, delete viaunsubscribe'sos.remove) since they all go throughget_feed_file_path.Added parametrized tests for rejected traversal patterns and accepted valid IDs
Related Issues
N/A
Documentation PR
N/A
Type of Change
Bug fix
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.