Skip to content

Remove bandit from linters#1279

Merged
mulkieran merged 1 commit into
stratis-storage:masterfrom
mulkieran:remove-bandit
Apr 21, 2026
Merged

Remove bandit from linters#1279
mulkieran merged 1 commit into
stratis-storage:masterfrom
mulkieran:remove-bandit

Conversation

@mulkieran
Copy link
Copy Markdown
Member

@mulkieran mulkieran commented Apr 21, 2026

Related stratis-storage/project#866
Related stratis-storage/project#64

Summary by CodeRabbit

  • Chores
    • Updated CI/build system dependencies and linting configuration.
    • Removed security linter suppressions from codebase.

@mulkieran mulkieran self-assigned this Apr 21, 2026
@mulkieran mulkieran moved this to In Progress in 2026April Apr 21, 2026
@mulkieran mulkieran marked this pull request as draft April 21, 2026 15:43
It is not supported in Fedora 43 and we expect to start using ruff for
Python linting in the near future.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran marked this pull request as ready for review April 21, 2026 19:44
@mulkieran
Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@mulkieran mulkieran moved this from In Progress to In Review in 2026April Apr 21, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3125f6dc-06f8-4b7d-ae7f-81963edb28c7

📥 Commits

Reviewing files that changed from the base of the PR and between da5df5a and 25e08e0.

📒 Files selected for processing (8)
  • .github/workflows/main.yml
  • Makefile
  • src/stratis_cli/_actions/_data.py
  • src/stratis_cli/_actions/_utils.py
  • tests/_misc.py
  • tests/integration/logical/test_list.py
  • tests/integration/physical/test_list.py
  • tests/integration/pool/test_list.py
💤 Files with no reviewable changes (1)
  • Makefile

Walkthrough

This PR removes bandit security scanning from the project by removing bandit from CI dependencies, eliminating all bandit invocations from the Makefile lint target, and stripping # nosec suppression comments throughout the codebase while preserving other linting directives.

Changes

Cohort / File(s) Summary
CI/Tooling Configuration
.github/workflows/main.yml, Makefile
Removed bandit from CI dependencies and replaced with python3-setuptools; removed all bandit invocations and the BANDIT_SKIP variable from the lint target.
Source Code
src/stratis_cli/_actions/_data.py, src/stratis_cli/_actions/_utils.py
Removed # nosec inline comments from XML parsing imports and ElementTree operations; retained other linting suppressions (pylint directives).
Tests
tests/_misc.py, tests/integration/logical/test_list.py, tests/integration/physical/test_list.py, tests/integration/pool/test_list.py
Removed # nosec comments from subprocess and ElementTree usage; simplified formatting in one generator expression; test logic and assertions remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove bandit from linters' accurately and concisely describes the primary change: bandit, a security linter, is being removed from the project's linting workflow across multiple files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mulkieran mulkieran merged commit 4ec9284 into stratis-storage:master Apr 21, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in 2026April Apr 21, 2026
@mulkieran mulkieran deleted the remove-bandit branch April 22, 2026 00:04
@mulkieran mulkieran moved this from Done to Done(3) in 2026April Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done(3)

Development

Successfully merging this pull request may close these issues.

1 participant