This repository was archived by the owner on Aug 16, 2021. It is now read-only.
[SC] Returning structs will be pretty in receipts #4094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowandh
reviewed
Nov 25, 2019
| /// <summary> | ||
| /// Get a string representation of a smart contract execution's return value. | ||
| /// </summary> | ||
| public static string GetSerializedReturnValue(object returnValue) |
Collaborator
There was a problem hiding this comment.
This definitely doesn't belong in the CoinViewRule. We should return the result object, and leave it up to the presentation layer (in this case, the API controller) to decide how to display structs.
Also, we will probably want to reuse this for deserializing local calls to methods where the return type is a struct.
Collaborator
|
Nice idea 💯 . Would be good if we can make it reusable and apply it in other places where struct deserialization would be useful! |
Collaborator
Author
|
I will do that, will componentise it soon as I get a chance |
fenix2222
reviewed
Nov 26, 2019
| return null; | ||
|
|
||
| // All primitives will come from "a real place". Return the standard string representation. | ||
| if (!String.IsNullOrEmpty(returnValue.GetType().Namespace)) |
Contributor
There was a problem hiding this comment.
User lowercase string for consistency
Collaborator
|
Looks like this problem exists for byte arrays too, see #4099. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.