Skip to content

refactor: omit unnecessary reassignment #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nuxtreact wants to merge 1 commit into
base: develop
Choose a base branch
from
+0 −3
Open

refactor: omit unnecessary reassignment #749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions orchestrator/stage/squash_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ func TestMultiSquashWithDifferentSegments(t *testing.T) {
mergeUnit := Unit{Stage: 0, Segment: 1}

for _, modState := range stage.storeModuleStates {
modState := modState
if mergeUnit.Segment < modState.segmenter.FirstIndex() {
continue
}
Expand Down Expand Up @@ -175,7 +174,6 @@ func TestMultiSquashErrorHandling(t *testing.T) {

// Simulate error in one of the goroutines
for idx := range stage.storeModuleStates {
idx := idx
stage.syncWork.Go(func() error {
if idx == 1 {
return assert.AnError // Simulate error in second module
Expand Down Expand Up @@ -327,7 +325,6 @@ func TestSyncWorkGroupBehavior(t *testing.T) {

// Spawn multiple goroutines with different execution times
for i := range 5 {
i := i
group.Go(func() error {
sleepTime := time.Duration(5-i) * 10 * time.Millisecond
time.Sleep(sleepTime)
Expand Down