feat: add capacity type node groups to allow for spot nodes #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@dpappa:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
github-actions
bot
removed
the
doc-info-missing
Contributor
|
@dpappa:Thanks for providing doc info! |
github-actions
bot
added
doc-required
Contributor
|
@dpappa:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
doc-info-missing
Contributor
|
@dpappa:Thanks for providing doc info! |
maxsxu
approved these changes
Dec 24, 2025
maxsxu
pushed a commit
that referenced
this pull request
Dec 24, 2025
🤖 I have created a release *beep* *boop* --- ## [4.5.0](v4.4.0...v4.5.0) (2025-12-24) ### Features * add capacity type node groups to allow for spot nodes ([#152](#152)) ([eb6f292](eb6f292)) * **iam:** add iam:ListInstanceProfiles permission for karpenter 1.7.0+ ([#171](#171)) ([b49e353](b49e353)) ### Bug Fixes * **iam:** make karpenter and cluster-autoscaler mutual exclusion ([#175](#175)) ([0998bb4](0998bb4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR will allow us to specify the capacity type, which is typically "on-demand". There are some instances where we would like to make node groups spot for cost savings on lower level environments.
Modifications
I've exposed the
node_pool_capacity_typewhich allows modification to the capacity types of all node groups created via the eks-managed-node-group submodule.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)