feat(server, html2pdf): implement better error reporting when Chrome is not found #2591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is not found **WHAT:** This change improves the error message when the StrictDoc web server cannot find a Chrome installation on the system it is running on. **WHY:** Before this change, the error message was a simple Internal Server Error without an explicit indication that the Chrome could not be found. A user would have to dig through the server logs to understand the issue. **HOW:** This integrates the upstream html2pdf4doc work where the error reporting was improved in the main.py driver program. In particular, the driver now exits with a specific exit code `COULD_NOT_FIND_CHROME = 5` that we can rely on in StrictDoc to identify the missing Chrome issue. strictdoc-project/html2pdf4doc_python#58 strictdoc-project/html2pdf4doc_python#70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT:
This change improves the error message when the StrictDoc web server cannot find a Chrome installation on the system it is running on.
WHY:
Before this change, the error message was a simple Internal Server Error without an explicit indication that the Chrome could not be found. A user would have to dig through the server logs to understand the issue.
HOW:
This integrates the upstream html2pdf4doc work where the error reporting was improved in the main.py driver program.
In particular, the driver now exits with a specific exit code
COULD_NOT_FIND_CHROME = 5that we can rely on in StrictDoc to identify the missing Chrome issue.strictdoc-project/html2pdf4doc_python#58 strictdoc-project/html2pdf4doc_python#70