Add discriminated union serialization tests - #2798
Closed
jar-stripe wants to merge 1 commit into
Closed
Conversation
Tests discriminated union type shapes for both request-side (params with literal discriminator) and response-side (object fields), covering standalone and inline variants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
Contributor
Author
|
Collapsed into #2801 (coercion PR now includes serialization tests) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Validates that the discriminated union serialization design works correctly in stripe-node before codegen produces these patterns. Exercises request-side encoding via
flattenAndStringify(the SDK's actual form-param encoder) and response-side TypeScript type narrowing.What?
test/DiscriminatedUnion.spec.tswith 29 tests covering:flattenAndStringify: Verifies bracket-notation output for nested variant params (color[model]=rgb,color[r]=255), optional field omission, and discriminator + payload encodingflattenAndStringify: Verifies top-level discriminator, nested variant payload encoding (card[number]=4242), base fields at top level, and non-selected variant absenceBaseFields & (VariantA | VariantB)), discriminator-based field access, non-selected variant null check, full base+variant field preservationflattenAndStringifyfor request direction, JSON parse for response direction